chore: use cargo git to pull all build dependencies #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -24,7 +24,7 @@ edition = "2021" | |||
| anyhow = "1.0.86" | |||
| borsh = { version = "1.2.1", features = ["derive", "unstable__schema"] } | |||
| cleanass = "0.0.1" | |||
| ephemeral-rollups-sdk = { path = "../../ephemeral-rollups-sdk/rust/sdk" } | |||
| ephemeral-rollups-sdk = { git = "https://github.com/magicblock-labs/ephemeral-rollups-sdk.git", rev = "c1fcb91" } | |||
There was a problem hiding this comment.
style: Consider using the full commit hash instead of the shortened 'c1fcb91' to prevent potential future hash collisions
GabrielePicco
approved these changes
Apr 30, 2025
taco-paco
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greptile Summary
Migrated dependency management from local paths to Git repositories, improving build reproducibility and simplifying CI/CD setup.
ephemeral-rollups-sdkintest-integration/Cargo.tomlfrom local path to Git dependency with revc1fcb91conjunto-transwiseandmagicblock-delegation-programin rootCargo.tomlto use Git dependencies.github/actions/setup-build-env/action.yml, leveraging Cargo's Git dependency resolution